Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook to API #32

Closed
bjendres opened this issue Jan 4, 2019 · 2 comments
Closed

Webhook to API #32

bjendres opened this issue Jan 4, 2019 · 2 comments
Labels
Milestone

Comments

@bjendres
Copy link
Member

bjendres commented Jan 4, 2019

Similar to #18 and #26, we want to proxy to be able to receive webhooks/callbacks and forward the configuration to the target system's API.

For that, this hook needs the following features:

  • multiple configurations, one default
  • IP/Range filter
  • parameter sources (POST/json, ...)
  • parameter sanitation
  • response processing (mapping of API response to HTTP status codes)
@bjendres bjendres added this to the 0.6 milestone Jan 4, 2019
bjendres added a commit that referenced this issue Feb 7, 2019
bjendres added a commit that referenced this issue Feb 7, 2019
bjendres added a commit that referenced this issue Feb 7, 2019
bjendres added a commit that referenced this issue Nov 26, 2019
@pbatroff
Copy link
Contributor

pbatroff commented Aug 3, 2022

This is implemented and works well with correct configuration setup.

In here and here return values from the internal CiviAPI is exposed.

I would propose to return 200 here and log the error internally to civiproxy_log, since the webhook got parsed and forwarded to the API correctly.

@bjendres do you have an opinion here?

This was already implemented, since the civi http code isn't returned, but 200 is always returned

@pbatroff
Copy link
Contributor

pbatroff commented Aug 3, 2022

I think we can close here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants