Deletes big activities, not small ones

[davidknoll]

In deleteActivities, the direction of the comparison for the number of contacts on the activity is the wrong way round. This means that it will delete mass activities, but not ones that only contain the anonymous contact.

• An activity containing me (as source), and the contact to be anonymised, and their school, is deleted entirely.
• An activity containing me (as source), and the contact to be anonymised, is deleted entirely.
• An activity containing only the contact to be anonymised (as both source and target) is not deleted, but all its ActivityContacts are deleted.

[davidknoll]

And another thing- I don't think it's purging the log table for civicrm_activity_contact.
It is purging the logs for civicrm_activity_contact, but only for the anonymised contact. Even if the entire activity is deleted, the log traces remain for other contacts. (Which is probably OK.)

[bjendres]

@davidknoll Thanks for the observations, we'll be probably looking into this extension in the next couple of months.

[bjendres]

Should be fixed with merging #2 and #3.

@davidknoll: Could you confirm that it's working correctly now?

[davidknoll]

Hi @systopia sorry for the delay, I only came back to this because I was tagged on Mattermost. We had kept a copy of Civi around for reference after we moved to Salesforce because we didn't migrate the whole of the activities and mailings history. In our GDPR preparations we eventually decided to kill this installation off entirely because nobody used it- so I'm afraid I never tested it, because we aren't using Civi any more.