Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standardised RegistrationProfile workflow calls #41

Open
bjendres opened this issue Mar 21, 2023 · 1 comment
Open

Add standardised RegistrationProfile workflow calls #41

bjendres opened this issue Mar 21, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@bjendres
Copy link
Member

Usually there needs to be a couple of things that need to happen in most complex profiles (beyond the validation)

  • mapping form submission values to contact fields (and custom contact fields)
  • mapping form submission values participant fields (and custom participant fields)
    This is needed if the submission field name doesn't match the (APIv3) custom field name.

This mapping is currently mostly implemented via Symfony hook on the civi.remoteevent.registration.submit event. This however, makes re-using the code difficult.

I would suggest to add a dummy adjustContactData(RegistrationEvent) and a dummy adjustPartipantData(RegistrationEvent) function, that is automatically called. This way, profile implementations can override these to ship the mappings along with the profile, and no need for registering to the symfony events.

@bjendres bjendres added the enhancement New feature or request label Mar 21, 2023
@bjendres bjendres added this to the 1.1 milestone Mar 21, 2023
@jensschuppe jensschuppe added enhancement New feature or request and removed enhancement New feature or request labels Oct 17, 2023
@jensschuppe jensschuppe modified the milestones: 1.1, 1.2 Oct 17, 2023
@jensschuppe jensschuppe modified the milestones: 1.2, 1.3 Mar 25, 2024
@jensschuppe
Copy link
Contributor

Moving to 1.3 as 1.2 is already in beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants