Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use resource BAO objects #12

Open
bjendres opened this issue Nov 12, 2021 · 2 comments
Open

Don't use resource BAO objects #12

bjendres opened this issue Nov 12, 2021 · 2 comments
Labels
enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code)

Comments

@bjendres
Copy link
Member

Currently, ECK objects will be used for resources (see #9). While they still have issues to be used with the BAO structure, this extension should not try to instantiate those linked entities as objects, but rather use the API
@bjendres bjendres added the enhancement New feature or request label Nov 12, 2021
bjendres added a commit that referenced this issue Nov 12, 2021
@bjendres
[#12] removed getEntity b/c not ECK compatible
5c0290c
bjendres added a commit that referenced this issue Nov 12, 2021
@bjendres
[#12] removed unused Resource::getEntity() function 'issue/12'
b28a47e
bjendres added a commit that referenced this issue Nov 12, 2021
@bjendres
[#12] removed getEntity b/c not ECK compatible
3f45201
bjendres added a commit that referenced this issue Nov 12, 2021
@bjendres
[#12] removed unused Resource::getEntity() function 'issue/12'
1242ab7
@bjendres
Copy link
Member Author

@jensschuppe is this 'fixed' now?

@jensschuppe
Copy link
Contributor

@bjendres I think so, at least I couldn't spot errors regarding the issue anymore.

@jensschuppe jensschuppe added the status:fixed The issue has been resolved (usually by committing/merging code) label Dec 1, 2021
jensschuppe added a commit that referenced this issue Dec 17, 2021
@jensschuppe
Re-implement CRM_Resource_BAO_Resource::getEntity, explicitly support…
a805828 
…ing ECK entities (Un-revert #12)
@jensschuppe jensschuppe mentioned this issue Dec 17, 2021
Merged
jensschuppe added a commit that referenced this issue Jan 5, 2022
@jensschuppe
Re-implement CRM_Resource_BAO_Resource::getEntity, explicitly support…
1f89532 
…ing ECK entities (Un-revert #12)
jensschuppe added a commit that referenced this issue Jan 6, 2022
@jensschuppe
Re-implement CRM_Resource_BAO_Resource::getEntity, explicitly support…
1a6fd81 
…ing ECK entities (Un-revert #12)
jensschuppe added a commit that referenced this issue Jan 6, 2022
@jensschuppe
Re-implement CRM_Resource_BAO_Resource::getEntity, explicitly support…
823565d 
…ing ECK entities (Un-revert #12)
jensschuppe added a commit that referenced this issue Jan 6, 2022
@jensschuppe
Re-implement CRM_Resource_BAO_Resource::getEntity, explicitly support…
d1fb54d 
…ing ECK entities (Un-revert #12)
jensschuppe added a commit that referenced this issue Jan 11, 2022
@jensschuppe
Re-implement CRM_Resource_BAO_Resource::getEntity, explicitly support…
9b3f852 
…ing ECK entities (Un-revert #12)
jensschuppe added a commit that referenced this issue Jan 21, 2022
@jensschuppe
Re-implement CRM_Resource_BAO_Resource::getEntity, explicitly support…
d0eea50 
…ing ECK entities (Un-revert #12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjendres @jensschuppe