Python driver implements DB-API. #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipr0
force-pushed
the
python
branch
3 times, most recently
from
52f5aab to
1352fec
Compare
szab100
reviewed
Apr 14, 2020
driver/python/cursor.py
Outdated
| self.rowcount = self._set_data(descriptors, resp.rows) | ||
| else: | ||
| self.rowcount = 0 | ||
| return True |
There was a problem hiding this comment.
Maybe this loop's structure could be refactored a bit or at least the order of the two resp.status == if statements could be flipped (and maybe use else-if for the 2nd), so it is better visible that we only retry if it's a REDIRECT
| with urlopen(self.health_check_url) as resp: | ||
| if HTTPStatus.OK == resp.getcode(): | ||
| return True | ||
| except URLError: |
There was a problem hiding this comment.
in which case(s) can we get an URLError here?
There was a problem hiding this comment.
Connection or internal DB errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests:
bazel test //driver/python:all_tests --test_output=streamed --runs_per_test=2