Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change fps without making a timeline #41

Open
t-makaro opened this issue Mar 8, 2019 · 1 comment
Open

Can't change fps without making a timeline #41

t-makaro opened this issue Mar 8, 2019 · 1 comment
Milestone

Comments

@t-makaro
Copy link
Owner

t-makaro commented Mar 8, 2019

I'm considering an API addition that allows:

anim = amp.Animation([block], fps=fps)

where fps gets passed to the constructor of Timeline when no timeline is passed.

Another option is to allow Timeline to accept an integer for t so one would do:

anim = amp.Animation([block], Timeline(len(block), fps=fps))

cc @TomNicholas Thoughts?

@t-makaro t-makaro added this to the 0.5.0 milestone Mar 8, 2019
@TomNicholas
Copy link
Contributor

Just seen this, I like the first option for an updated API.

I wonder if it perhaps makes more sense to think of the Timeline object as containing information about the slider, whereas fps would be a property of the Animation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants