Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md for PR #320

Closed
t-will-gillis opened this issue Sep 5, 2023 · 0 comments
Closed

md for PR #320

t-will-gillis opened this issue Sep 5, 2023 · 0 comments

Comments

@t-will-gillis
Copy link
Owner

Fixes # 4788

What changes did you make?

  • VERIFY WE SHOULD DO THIS: On schedule-monthly.yml the previous two steps for "- name: Checkout repository" and "- name: Setup node" have been replaced with the current single step "- name: Github action for installing npm dependencies".

  • Since the current schedule-thu-1100.yml was scheduled to run on the first Thursday of the month, this action has been revised/ renamed to schedule-monthly.yml and now is scheduled to run on the first day of the month.

  • Because of this change, there no longer is a schedule-thu-1100.yml file.

  • Note that there is an existing action (Fix bug that prevents GHA "Schedule Monthly" from running  hackforla/website#4788) with the same name. This action/ file is renamed schedule-monthly-PREV.yml. This action is not/ has not been running either. The renaming is intended to be temporary because the plan is to explore how to integrate the other action's steps into this action.

  • The "Get current date" step in the .yml file was deleted because a.) the code is deprecated and b.) it is unnecessary. (The previous file used this step to cause the automation to run only on the first Thursday of the month.)

  • The working-directory in the step "Install npm dependencies" is refactored to the correct directory i.e. ./github-actions/trigger-schedule/github-data. (This was one of the reasons the existing GHA has not worked- this refactor fixes the action.)

  • The node-version is updated to version 18. (The previous version 14 is incompatible with the current modules.)

  • The run path in the step "Trim members" is refactored to the correct directory and the contributors-data.js is moved to the same directory as above. (This was another one of the reasons the existing GHA was not working. The @octokit/rest module cannot be found unless the js file resides in the same directory as the package.json file.)

  • Since this js file is moved, the trim-contributors directory is empty and so is deleted.

  • Additional functionality has been added to contributors-data.js:

    • The automatic removal of members now occurs after two months of inactivity.
    • Members who are one month inactive are placed on list so that they can be contacted. (For a future PR, an automatic notification should be sent to these members to give them a chance to become active again before deletion= See "FUTURE revisions/ additions" below)
  • Since files have been renamed and moved, the "Files changed" link above will not give a useful comparison of what is different. See the 'Diffchecker' screenshots below.

Why did you make the changes (we will use this info to test)?

  • Changes were made primarily to get this action working again (it has been failing for over a year due to misdirected file paths.)
  • Other reasons are given in the text above.

FUTURE revisions/ additions are detailed in ER hackforla#5163

Screenshots of Proposed Changes Of The Website

Diffchecker for new `schedule-monthly.yml`

Screenshot 2023-08-07 at 14-53-59 Computed Diff - Diff Checker

Diffchecker for `contributors-data.js`

Screenshot 2023-08-07 at 14-20-30 contributors-data js - Diff Checker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: QA
Development

No branches or pull requests

1 participant