Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need debug logging when authorization failed #173

Open
tototoshi opened this issue Apr 29, 2016 · 2 comments
Open

Need debug logging when authorization failed #173

tototoshi opened this issue Apr 29, 2016 · 2 comments

Comments

@tototoshi
Copy link
Contributor

When authorization failed from exception thrown by underlying modules like db or cache api, the detail is ignored and not recorded. Due to this, debugging is very hard.

https://github.com/t2v/play2-auth/blob/release0.14.2/module/src/main/scala/jp/t2v/lab/play2/auth/AsyncAuth.scala#L9-L22

Will you add debug logging where recover and recoverWith?

} recoverWith {
      case e =>
           logger.debug(e.getMessage, e)
           authenticationFailed(request).map(Left.apply)
}
@gakuzzzz
Copy link
Member

gakuzzzz commented Jun 1, 2016

Good proposal!

I consider the way of getting logger instance...

@tototoshi
Copy link
Contributor Author

why not play.api.Logger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants