Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache hit / miss math #128

Open
daniellienert opened this issue Dec 21, 2020 · 1 comment
Open

Cache hit / miss math #128

daniellienert opened this issue Dec 21, 2020 · 1 comment

Comments

@daniellienert
Copy link
Contributor

The cache hit / miss sums are wrong most of the times.

Example:

image
@Sebobo
Copy link
Collaborator

Sebobo commented Dec 22, 2020

Yes, for the absolute sum we should use the information from the individual blocks. I fixed some bugs there recently and they should be correct now.

The current numbers are generated from the calls and results of replaceCachePlaceholders and getCachedSegment. The question is whether it's correct that we have less cache calls than cached segments or not and if it's correct we also have to show those numbers.
Did you dig deeper into that already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sebobo @daniellienert