Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching information missing for uncached segments #165

Open
ghost opened this issue Nov 24, 2021 · 3 comments
Open

Caching information missing for uncached segments #165

ghost opened this issue Nov 24, 2021 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 24, 2021

Caching information is only collected when the entryIdentifier contains a "format = 'html'", uncached elements do not contain a 'format' in the entryIdentifier, this is only mandatory for 'cached' or 'dynamic'.

Offending lines:

// Add debug data only to html output
$segmentFormat = $info['entryIdentifier']['format'] ?? null;

if ($segmentFormat !== 'html') {
    return $segment;
}

See commit: b46cc51

@Sebobo
Copy link
Collaborator

Sebobo commented Nov 3, 2022

Do you already have an idea how to solve this better?

@freesh
Copy link

freesh commented Nov 26, 2022

Im wondering why uncached shouldn't have an identifier too.

@Sebobo
Copy link
Collaborator

Sebobo commented Nov 27, 2022

What would be the use?

And we cannot add the debug data if we don't know what kind of data is returned. I'm sure there is a good way to solve this, but I haven't had the incentive yet to investigate. So any outside input would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants