Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide module-info.java #22

Open
AlexElin opened this issue Mar 1, 2023 · 1 comment
Open

Provide module-info.java #22

AlexElin opened this issue Mar 1, 2023 · 1 comment

Comments

@AlexElin
Copy link

AlexElin commented Mar 1, 2023

At the moment this library can't be depend on it as a java module becasue the library neither contain a module descriptor (module-info.java) nor have Automatic-Module-Name: <module name> entry in the library's MANIFEST.MF.

I propose to add module-info.java (becasue the library is java 9+). So, it'll be possible to depend on in the client's module-info.java

@t9t
Copy link
Owner

t9t commented Mar 5, 2023

Thanks for taking the time to report this issue!

I'm quite busy right now, but I will look into this next week. Unfortunately I'm not quite familiar with module-info.java yet, so I will need to read up on it.

If you know how to do it and have time, feel free to create a Pull request for it. If not, no problem!

t9t added a commit that referenced this issue Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants