Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused convolutional layers #1

Open
sotwi opened this issue Mar 20, 2022 · 1 comment
Open

Unused convolutional layers #1

sotwi opened this issue Mar 20, 2022 · 1 comment

Comments

@sotwi
Copy link

sotwi commented Mar 20, 2022

Hello @taasnim I am looking into your code because I'm trying to implement a similar system to evaluate my Text Generation project.

While looking into the code I ran into what looks like a mistake in lines 198 to 202 of the model.py code.

During initialization (and according to your paper) there should be 6 convolutional layers. However, during the forward pass you use the first 4 layers and then, in lines 198 to 202 instead of calling layers 5 and 6 you call layers 3 and 4 again. In practice, layers 5 and 6 are never really used.

@taasnim
Copy link
Owner

taasnim commented Mar 28, 2022

Hi @sotwi,
Thanks for figuring it out.
In my local repository, I updated the issue long ago but forgot to make a push here.
Anyway, I updated the code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants