Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate test case #58

Open
amn opened this issue May 11, 2024 · 1 comment
Open

Duplicate test case #58

amn opened this issue May 11, 2024 · 1 comment

Comments

@amn
Copy link
Contributor

amn commented May 11, 2024

The following two tests are identical:

parse-css/tests.js

Lines 331 to 335 in c7859c4

{
parser: "",
css: "null\\0",
expected: [{type: "IDENT", value: "null\uFFFD"}, {type: "EOF"}],
},

parse-css/tests.js

Lines 336 to 340 in c7859c4

{
parser: "",
css: "null\\0",
expected: [{type: "IDENT", value: "null\uFFFD"}, {type: "EOF"}],
},

I think that is an omission of sorts, I see no value in having both, am I missing something?

amn added a commit to amn/parse-css that referenced this issue May 11, 2024
@danny0838
Copy link
Contributor

This is migrated from the source code of Chromium, and it seems to be a simple slip, and it should be OK to fix it with #59. Thank you.

tabatkins pushed a commit that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants