From 2d62c9513be34bf882405a986becc7c3fc3f7210 Mon Sep 17 00:00:00 2001 From: Brian Cantoni Date: Wed, 12 Jun 2024 08:39:18 -0700 Subject: [PATCH 1/3] Fix logic in test_list_sites E2E test --- tests/e2e/online_tests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/e2e/online_tests.py b/tests/e2e/online_tests.py index 05a9b6a9..27cf5916 100644 --- a/tests/e2e/online_tests.py +++ b/tests/e2e/online_tests.py @@ -468,10 +468,11 @@ def test_list_sites(self): if not server_admin: pytest.skip("Must be server administrator to list sites") + result = True command = "listsites" try: _test_command([command]) except Exception as E: print("yay") - result = True + result = False assert result From cfb5ff8baf3eea9d589e2f6cf536b777eaf41db0 Mon Sep 17 00:00:00 2001 From: Brian Cantoni Date: Wed, 12 Jun 2024 08:39:50 -0700 Subject: [PATCH 2/3] Update dependencies - move TSC pin to latest 0.31 - relax urllib3 version range to avoid conflict w/TSC --- pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 7a818c8f..3144501c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -54,8 +54,8 @@ dependencies = [ "types-mock", "types-requests", "types-setuptools", - "tableauserverclient==0.25", - "urllib3>=1.24.3,<2.0", + "tableauserverclient==0.31", + "urllib3", ] [project.optional-dependencies] test = [ From 413abc8486b16db8cda3b1ecf8fdd875f90305d6 Mon Sep 17 00:00:00 2001 From: Brian Cantoni Date: Wed, 12 Jun 2024 11:33:20 -0700 Subject: [PATCH 3/3] Drop the extra yay message :) --- tests/e2e/online_tests.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/e2e/online_tests.py b/tests/e2e/online_tests.py index 27cf5916..6b502280 100644 --- a/tests/e2e/online_tests.py +++ b/tests/e2e/online_tests.py @@ -473,6 +473,5 @@ def test_list_sites(self): try: _test_command([command]) except Exception as E: - print("yay") result = False assert result