Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in XmlArrayItem for Views in CommitWorkbookPublishRequest.cs #31

Closed
Jodolod opened this issue Aug 13, 2024 · 2 comments
Closed

Typo in XmlArrayItem for Views in CommitWorkbookPublishRequest.cs #31

Jodolod opened this issue Aug 13, 2024 · 2 comments

Comments

@Jodolod
Copy link

Jodolod commented Aug 13, 2024

Hello,

there seems to be a typo in the XmlArrayItem for views. Both the XmlArray and the XmlArrayItem are called views but if I read the REST Api documentation correctly the XmlArray should be called views and the XmlArrayItem should be called view or am I mistaking?

I attached the example from the documentation below

Best

--boundary-string
Content-Disposition: name="request_payload"
Content-Type: text/xml
<tsRequest>
  <workbook name="workbook-name" showTabs="show-tabs-flag" thumbnailsUserId="user-luid" >
    <connections>
      <connection serverAddress="server-address" serverPort="port-number">
        <connectionCredentials name="connection-username" password="connection-password"
           embed="embed-flag" oAuth="oauth-flag" />
	  </connection>
	</connections>
	<views>
      <view name="view-name" hidden="hide-view-flag" />
	</views>
	<project id="project-id"/>
  </workbook>
</tsRequest>
--boundary-string--

Docs

@tdemoraisribeiro
Copy link
Collaborator

Thanks for reporting this issue. It will be fixed in the next release.

@pvshn
Copy link
Collaborator

pvshn commented Sep 3, 2024

The fix is in v4.3.0

@pvshn pvshn closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants