Refactoring? #5
Comments
|
Ryan,
Give me call on Hangouts or send a meeting invite.
Ross
…On Fri, Mar 22, 2019 at 6:09 AM sreyemnayr ***@***.***> wrote:
Hi Ross,
I'd like to contribute more to this tool (potential ideas include writing
tests, more helpful exception messages, a gui/cli tool with prompts,
amongst others) but the file size of the main gam.py is pretty unwieldy.
Would you be open to me breaking it into some smaller modules that might be
a little easier to work with?
I'm also going to try to contribute some sample commands to the docs when
I figure them out. Some areas of the wiki are super helpful, and others are
pretty sparse. All of which is incredibly helpful! Not meaning to be picky
about a fantastic open source project, but just willing to contribute back
if it's desired.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIU8L2GtNlfcTLjaVbYGb5NU2hvvp3ulks5vZNX5gaJpZM4cDiKK>
.
--
Ross Scroggs
[email protected]
|
|
Ryan,
All help will be much appreciated. Let me know when we can talk about a
strategy for going forward.
Thanks for the offer,
Ross
On Fri, Mar 22, 2019 at 10:05 AM Ross Scroggs <[email protected]>
wrote:
… Ryan,
Give me call on Hangouts or send a meeting invite.
Ross
On Fri, Mar 22, 2019 at 6:09 AM sreyemnayr ***@***.***>
wrote:
> Hi Ross,
> I'd like to contribute more to this tool (potential ideas include writing
> tests, more helpful exception messages, a gui/cli tool with prompts,
> amongst others) but the file size of the main gam.py is pretty unwieldy.
> Would you be open to me breaking it into some smaller modules that might be
> a little easier to work with?
> I'm also going to try to contribute some sample commands to the docs when
> I figure them out. Some areas of the wiki are super helpful, and others are
> pretty sparse. All of which is incredibly helpful! Not meaning to be picky
> about a fantastic open source project, but just willing to contribute back
> if it's desired.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#5>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AIU8L2GtNlfcTLjaVbYGb5NU2hvvp3ulks5vZNX5gaJpZM4cDiKK>
> .
>
--
Ross Scroggs
***@***.***
--
Ross Scroggs
[email protected]
|
|
Ryan, Let me know when you've got a few minutes to map out a plan. Ross |
|
Hey Ross, sorry I got slammed with a huge project like an hour after sending that. I should be freed up at the end of this week. Does Thurs/Fri work for you?
Ryan
…________________________________
From: Ross Scroggs <[email protected]>
Sent: Monday, March 25, 2019 4:28 PM
To: taers232c/GAMADV-XTD3
Cc: sreyemnayr; Author
Subject: Re: [taers232c/GAMADV-XTD3] Refactoring? (#5)
Ryan,
Let me know when you've got a few minutes to map out a plan.
Ross
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#5 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIKYTgWQWxjBNwVBnezZaFdx6KMCOkmeks5vaT9ngaJpZM4cDiKK>.
|
|
Yes, I'm in PDT and am usually at school by 7:30AM.
Ross
…On Mon, Mar 25, 2019 at 2:29 PM sreyemnayr ***@***.***> wrote:
Hey Ross, sorry I got slammed with a huge project like an hour after
sending that. I should be freed up at the end of this week. Does Thurs/Fri
work for you?
Ryan
________________________________
From: Ross Scroggs ***@***.***>
Sent: Monday, March 25, 2019 4:28 PM
To: taers232c/GAMADV-XTD3
Cc: sreyemnayr; Author
Subject: Re: [taers232c/GAMADV-XTD3] Refactoring? (#5)
Ryan,
Let me know when you've got a few minutes to map out a plan.
Ross
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<
#5 (comment)>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AIKYTgWQWxjBNwVBnezZaFdx6KMCOkmeks5vaT9ngaJpZM4cDiKK
>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIU8LwT8NVujcCOYkx90jZSDY8iLYFuBks5vaT_NgaJpZM4cDiKK>
.
--
Ross Scroggs
[email protected]
|
|
Sorry @taers232c , life got crazy there for a second! Are you available to loop back to this next week? |
|
Yes
--
[email protected]
… On Jul 4, 2019, at 6:08 AM, sreyemnayr ***@***.***> wrote:
Sorry @taers232c <https://github.com/taers232c> , life got crazy there for a second! Are you available to loop back to this next week?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=ACCTYL6WV2VX7NPPDFC6TY3P5XY6HA5CNFSM4HAOEKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZHL25I#issuecomment-508476789>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCTYLZPTIS5OKXIPXANINLP5XY6HANCNFSM4HAOEKFA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Ross,
I'd like to contribute more to this tool (potential ideas include writing tests, more helpful exception messages, a gui/cli tool with prompts, amongst others) but the file size of the main gam.py is pretty unwieldy. Would you be open to me breaking it into some smaller modules that might be a little easier to work with?
I'm also going to try to contribute some sample commands to the docs when I figure them out. Some areas of the wiki are super helpful, and others are pretty sparse. All of which is incredibly helpful! Not meaning to be picky about a fantastic open source project, but just willing to contribute back if it's desired.
The text was updated successfully, but these errors were encountered: