Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal deployment example #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Miladiir
Copy link

Closes #151

@Miladiir
Copy link
Author

Sorry, not going to fix the bot. I am doing this from a phone. I give full permission to use the above commits to do whatever they want with it, respecting the original licenses. (or whatever). Feel free to do this under your own name, without attribution.

).run_commands(["go install -v github.com/tailscale/golink/cmd/golink@latest"])
).run_commands([
"go install -v github.com/tailscale/golink/cmd/golink@latest",
"rm -rf /root/.config"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/root/.config/golinks.db is removed by this command if I understand correctly. I believe this volume was added intentionally.

Copy link
Author

@Miladiir Miladiir Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs before volume is mounted. If you don’t do this there is some go telemetry crap in the folder and modal cannot mount the storage volume into the mountpath.

Modal is weird. I really do not like it 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just the go telemetry data, I believe there is an env var we can set to turn that off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal deployment does not maintain stable name
3 participants