Markup appears during presentation on macOS

[Lownin]

Not sure if this is an issue with Doom or org-tree-slide...

Using doom emacs railwaycat/emacsmacport/emacs-mac on macOS, markup characters are shown during the presentation. This does not seem to occur on Ubuntu using ppa:kelleyk/emacs

FWIW, markup in the headings renders without showing the markup during the presentation correctly. It's just when its in the content.

macOS:

Ubuntu:

[takaxp]

In my understanding, showing two ~ is correct because org-tree-slide doesn't provide such feature of hiding markups. I guess a function is set to org-tree-slide-play-hook in your side on Ubuntu for hiding two ~, otherwise just org-hide-emphasis-markers is non-nil in your init.el or somewhere.

I think it is good idea to implement a feature to control hide the markups when presenting as you mentioned, and a toggle function to hide and show markups during presentation. But for now updating README is sufficient for many user on describing how to hide and/or show markups, or about combined configurations with https://github.com/awth13/org-appear.

[Lownin]

Interesting. I did a fresh install of Doom Emacs on a fresh macOS and Ubuntu VM to test this, and the behavior was similar to Ubuntu on macOS as of some weeks ago as well if I remember correctly.

I don't see a toggle function org-hide-emphasis-markers available to me via my meta menu. I do see it called inside modules/lang/org/autoload/org.el for (define-minor-mode +org-pretty-mode

I've tried activating and deactivating +pretty for org-mode in the init.el on both Ubuntu and macOS, but the behavior is the same. Similarly the same when I invoke it manually during the presentation.

I apologize if my troubleshooting is indirect. I'm pretty early in my emacs journey.

[takaxp]

No problem :)
Actually, today I installed DOOM Emacs for the first time so nothing I know about DOOM Emacs.
I didn't know that the minor mode is implemented in autoload/org.el to configure org-hide-emphasis-markers. As you mentioned, we can use M-x org-pretty-mode as a toggle function. So I think this issue is done.

[Lownin]

@takaxp my appologies if unclear. When I toggle M-x org-pretty-mode, it does not remove the markup display. In fact, it unhides the markup from the headings. Let me know if you would like me to include a gif.

[takaxp]

OK, I cannot reproduce the error in my minimal configuration, please see my captured video.

a.mov

The primal difference is the face of each heading. I guess org-bullet or other package is integrated in your environment. So could you provide me information about org-related packages you installed or activated in DOOM?

[Lownin]

This is on a fresh Big Sur VM, 11.6.7
emacs installed with

brew tap railwaycat/emacsmacport
brew install emacs-mac --with-native-comp --with-modules

Doom installed per their docs.
The only change from default is in my ~/.doom.d/init.el
I changed the line from

org               ; organize your plain life in plain tex

to

(org +present)               ; organize your plain life in plain tex

in order to install and test org-tree slide, and ran a doom sync and restarted Emac.

I am able to reproduce your video when in standard org mode, but when switching to org-tree-slide it's as described initially.

Standard org-mode
https://user-images.githubusercontent.com/8387063/179323132-fcf8aeac-bd41-4952-93af-60cb86d06ea0.mov

org-mode-pretty-toggle.mov

org-tree-slide

org-tree-slide-pretty-toggle.mov

[takaxp]

Thanks! BTW, have you removed (setq org-fold-core-style 'overlay) from your environment? Now I can reproduce the issue if I use the following setting in config.el of DOOM. If not yet, please visit #54 first and resolve it not to rely on changing org-fold-core-style.

(after! org-tree-slide
        (setq debug-on-error t)
        (setq org-fold-core-style  'overlay))

[Lownin]

Removing (setq org-fold-core-style 'overlay) and making the change described in #54 did improve things. Now, however, I am getting a minor formatting annyance in code blocks, with "..." showing where it didn't before.

[takaxp]

Thank you for updating code in your side. I confirmed that the change in #54 is not sufficient to do thing well in DOOM. So I'll have to investigate little bit more especially applying a profile (e.g. simple profile after activating org-tree-slide-mode).