Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legends for side colour plots #35

Closed
alanocallaghan opened this issue Mar 8, 2017 · 5 comments
Closed

Legends for side colour plots #35

alanocallaghan opened this issue Mar 8, 2017 · 5 comments

Comments

@alanocallaghan
Copy link
Collaborator

alanocallaghan commented Mar 8, 2017

Currently layout(showlegend=FALSE) is run on the subplot object. This prevents any modifications of the colorbar using colorbar() but it also hides the legend for the side colour plots (and dendrogram traces). We can get around this by setting show_legend on the actual plotly objects as they are created. Unfortunately this is not consistent between plot_ly(..., showlegend=FALSE) and ggplotly() %>% layout(showlegend=FALSE). Furthermore, after adding the extra legend, it will be necessary to dodge the colorbar and the trace legend

Example of all legends together: http://imgur.com/a/TN7UK

@alanocallaghan
Copy link
Collaborator Author

It may be necessary to transition the side colour plots to native plotly to be able to fully control this

@alanocallaghan
Copy link
Collaborator Author

An (ugly) workaround is to set the overall legend y position to zero, which puts it at the bottom, hopefully out of the way of the colorbar. Ideally you would allow the user to move and resize both.

http://i.imgur.com/GC5rX5A.png

@alanocallaghan
Copy link
Collaborator Author

It seems that plotly doesn't respect colorbar adjustments in subplots for some reason. I'll raise an issue over there shortly

@talgalili
Copy link
Owner

Thanks for taking this issue on @alanocallaghan

Tal

@alanocallaghan
Copy link
Collaborator Author

Can be dealt with in #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants