Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monocot pipelines #52

Closed
talmo opened this issue Aug 17, 2023 · 1 comment
Closed

Add monocot pipelines #52

talmo opened this issue Aug 17, 2023 · 1 comment

Comments

@talmo
Copy link
Contributor

talmo commented Aug 17, 2023

In #51, we defined a new Pipeline base class and the DicotPipeline subclass which derives from it and implements the trait pipeline for dicot traits.

We now need to implement monocot pipelines which implement the specific logic for young and mature monocots.

These should implemented the define_traits and get_initial_frame_traits methods appropriately, including setting the appropriate monocot flags for individual trait computation functions, skipping traits that aren't used for those species, and dealing with renaming or missing lateral/primary/main root types.

@eberrigan
Copy link
Collaborator

eberrigan commented Mar 26, 2024

This issue has been resolved by the merged pull request #54 . Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants