Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp file operations for improvements #6

Open
maxirmx opened this issue Aug 22, 2023 · 2 comments
Open

Temp file operations for improvements #6

maxirmx opened this issue Aug 22, 2023 · 2 comments

Comments

@maxirmx
Copy link
Member

maxirmx commented Aug 22, 2023

  1. Original Ocra package installs full packaged solution into temp folder
  2. Upon exit Ocra package attempts to delete all installed files recursively (the code looks correct)
  3. If step 2 failes Ocra package marks remaining items for deletion upon reboot (https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-movefileexa with MOVEFILE_DELAY_UNTIL_REBOOT)
  4. If step 2 fails Ocra package marks the whole temp folder for deletion when Ocra is run next time
  5. On the next execution Ocra package looks for folders marked for deletion and applies steps starting from 2 to such folders

I guess steps 4,5 may look suspicious for AV software since Ocra package starts its operation from deleting some files that where on the system before the start.

I was not able to reproduce any of the issues so far

Inherited from
metanorma/packed-mn#207
metanorma/ocra#11

@ronaldtse
Copy link
Contributor

@maxirmx as mentioned in metanorma/ocra#11 (comment) I have also encountered that issue before, where Ocra does not cache previous expansions.

@maxirmx
Copy link
Member Author

maxirmx commented Aug 23, 2023

I suggest I will remove file deletion on startup first to see if it improves AV response
If it does, I will add caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants