Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./play.sh snapshots/space_invaders_200.pkl error out #23

Open
mw66 opened this issue Jun 26, 2016 · 2 comments
Open

./play.sh snapshots/space_invaders_200.pkl error out #23

mw66 opened this issue Jun 26, 2016 · 2 comments

Comments

@mw66
Copy link

mw66 commented Jun 26, 2016

./play.sh got the rom name wrong, it invokes:

python src/main.py --play_games 1 --display_screen true --load_weights snapshots/space_invaders_200.pkl roms/space.bin

while it should be space_invaders.bin

@tambetm
Copy link
Owner

tambetm commented Jun 27, 2016

Yes, this problem was already raised in pull request #6. But I couldn't accept the proposed fix, because it broke the (optional) experiment label feature. I guess different separator should be used for experiment label, for example -. I will keep it open until I have time to fix it, you're welcome to submit a pull request.

@mw66
Copy link
Author

mw66 commented Jun 28, 2016

train.sh works :-)

./train.sh roms/space_invaders.bin

python src/main.py --save_weights_prefix snapshots/space_invaders --csv_file results/space_invaders.csv roms/space_invaders.bin

game=${full%.*}

instead of

game=${full%%_*}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants