-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favourites has no mixes() function to get the favourite mixes #197
Comments
It seems you are right, mixes seem to be missing from favorites. Feel free to add a PR, otherwise this will be added as soon as possible. |
I tried to add this feature myself, but I think it's not possible for now. To get the favourite mixes it does: instead for example for the albums it does: |
After looking further into this issue, it seems we already have a partial functionality for getting mixes found in your collection.
Anyways, this does not currently work (for me, this page is just empty). Perhaps for legacy purposes? As you correctly point out, using the same approach as albums does not work as expected. But if you use the web player to get favourite albums / mixes, you will notice that both of them use the v2 URL for the GET method. The python-tidal API was probably reverse engineered using an earlier version. Perhaps it is possible to get the correct path to the mixes endpoints, using the v1 URL instead. Or perhaps the mixes endpoint does not exist for v1 - only v2? |
After doing some exploratory testing, it's definitely possible to get the mixes from favourites. |
Great to hear you found a solution. Perhaps we should consider using v2 links elsewhere in tidalapi. |
I ended up having to create a MixV2 class as the structure is different enough to warrant it, however, this structure is only used for this one v2 api endpoint, and tidal themselves in their web app use the v1 api for every other call related to mixes. It's a rather odd situation as you need to use the v2 endpoint to return a list of something that you then actually only ever need the name and ID of really. I'll push a draft PR to make what I'm talking about a bit more tangible. |
@jozefKruszynski Great to hear you found a solution. I'll test out your pr and get it merged ASAP so we can get this feature in for the next release. |
Fixed in #207 (Thanks @jozefKruszynski ). Merged into master today, will be added to next release asap. |
I checked the website and it is possible to see the favourite mixes and radios at https://listen.tidal.com/my-collection/mixes
Also adding/removing a mix from the favourite is not possible
The text was updated successfully, but these errors were encountered: