Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links for some plots in vignettes depending on the link #1

Open
tzeitim opened this issue Dec 14, 2023 · 1 comment
Open

Broken links for some plots in vignettes depending on the link #1

tzeitim opened this issue Dec 14, 2023 · 1 comment

Comments

@tzeitim
Copy link

tzeitim commented Dec 14, 2023

There are some images that seem to be rendered wrong depending on the url of the notebook. It seems that github has some inconsistencies in the relative paths (or something like that) depending on how notebooks are accessed.

For example, the iterative notebook accessed here:

https://tanaylab.github.io/metacells-vignettes/iterative.html

Is missing some of the figures (an example below).

The same notebook using a different (blob) url is well-rendered

https://github.com/tanaylab/metacells-vignettes/blob/main/notebooks/iterative.ipynb

The faulty links are the ones in the README so it's an easy fix to prevent users from reaching the faulty one.

Example:

For example, HBB is noisy, but is a clear erythrocytes marker, so it should not be lateral:

Has this url
https://tanaylab.github.io/images/high-inner-fold.HBB.svg

The image can be found, however:

https://github.com/tanaylab/metacells-vignettes/blob/main/images/high-inner-fold.HBB.svg

@tzeitim
Copy link
Author

tzeitim commented Dec 14, 2023

Well, after spending more time working on the link that "works" I see that some images (e.g. color bars) are not rendering well there so it's one thing for another ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant