Fix@format string is not a string literal (#14)

* fixed format string is not a string literal warning * added cran comments * updated NEWS.md * updated CRAN-SUBMISSION file
tanaylab · Jan 4, 2024 · 21a8bb9 · 21a8bb9
1 parent ed08d3a
commit 21a8bb9
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 8 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -1,3 +1,3 @@
-Version: 2.3.24
-Date: 2023-06-27 08:23:12 UTC
-SHA: b75c8ba59bc39a14e009895decc000a3238fed80
+Version: 2.3.25
+Date: 2023-11-29 11:05:04 UTC
+SHA: 58b2684aead46b1a0551e7f87b1a2c279d947508
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: tgstat
 Title: Amos Tanay's Group High Performance Statistical Utilities
-Version: 2.3.24
+Version: 2.3.25
 Authors@R: c(
     person("Michael", "Hoichman", , "[email protected]", role = "aut"),
     person("Aviezer", "Lifshitz", , "[email protected]", role = c("aut", "cre"))

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# tgstat 2.3.25
+
+* Fixed clang warnings.
+
 # tgstat 2.3.24
 
 * Fixed compilation errors on clang17.

diff --git a/cran-comments.md b/cran-comments.md
@@ -4,7 +4,7 @@
 
 ## Changes
 
-* Fixed compilation errors on clang17.
+* Fixed clang warnings 
 
 
 

diff --git a/src/tgstat.cpp b/src/tgstat.cpp
@@ -484,8 +484,9 @@ void TGStat::handle_error(const char *msg)
 			}
 		}
 		rexit();
-	} else
-        errorcall(R_NilValue, msg);
+	} else {
+        errorcall(R_NilValue, "%s", msg);
+    }
 }
 
 void TGStat::set_alarm(int msecs)
@@ -695,7 +696,7 @@ void vdebug(const char *fmt, ...)
     	va_start(ap, fmt);
     	vsnprintf(buf, sizeof(buf), fmt, ap);
         va_end(ap);
-        REprintf(buf);
+        REprintf("%s", buf);
 
         if (!*fmt || (*fmt && fmt[strlen(fmt) - 1] != '\n'))
             REprintf("\n");
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,7 +4,7 @@

		## Changes

		* Fixed compilation errors on clang17.
		* Fixed clang warnings



Expand Down