Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A BUG: can not find "cxxabi.h" #804

Closed
Oliver001 opened this issue Jun 23, 2016 · 7 comments
Closed

A BUG: can not find "cxxabi.h" #804

Oliver001 opened this issue Jun 23, 2016 · 7 comments

Comments

@Oliver001
Copy link

There are maybe a mistake in file ./toolchains/android.toolchain.cmake at line 1039.
set( ANDROID_ABI_INCLUDE_DIRS "${ANDROID_CXX_ROOT}/llvm-libc++abi/include" )

and I find the correct dir of ANDROID_ABI_INCLUDE_DIRS is "${ANDROID_CXX_ROOT}/llvm-libc++abi/libcxxabi/include"
so the line 1039 must be set( ANDROID_ABI_INCLUDE_DIRS "${ANDROID_CXX_ROOT}/llvm-libc++abi/libcxxabi/include" )

@matteblair
Copy link
Member

Good eye. Did you encounter an error related to this while building the library in a particular configuration?

@Oliver001
Copy link
Author

I don't think it happens in a particular configuration. In fact, the file cxxabi.h in the path ${ANDROID_CXX_ROOT}/llvm-libc++abi/libcxxabi/include correctly.

@matteblair
Copy link
Member

So it sounds like this isn't actually causing a problem with the build process. Is that correct?

The android.toolchain.cmake file was written by another open-source project, not by us, so I don't want to modify it unless we are very confident that it is causing a problem.

@Oliver001
Copy link
Author

Oliver001 commented Jun 29, 2016

It's up to you.
I find there are two guys tried add support for libc++, in this page taka-no-me/android-cmake#36, you can find the line 1039 in the second 'abergmeier added a note on Mar 4, 2015'.
And the other try in this page, taka-no-me/android-cmake@2959905 line 1043.

Can you tell me the android.toolchain.cmake file was written by which open-source project?

@karimnaaji
Copy link
Member

Hi @Oliver001 , I remember adding the support for c++ shared a while back 67f0411 (and the cmake file was originally taken from the project you mentioned).

Unfortunately, this part might not work for all the android NDKs since it's highly adapted for our needs, we will be more specific in our README and specify that we currently develop under android-r10e NDK (https://github.com/tangrams/tangram-es#android).

We are also waiting for the new android studio which has CMake support before investing time in adapting this toolchain for all configurations (Refer #807).

@matteblair
Copy link
Member

We got the toolchain file from https://github.com/taka-no-me/android-cmake but then had to make some additions and corrections, and actually that line you pointed out was one of the things we added! After realizing that and testing the include path, I went ahead and made the change you suggested: b979ac7

@Oliver001
Copy link
Author

Hi @karimnaaji, the new stable android studio which has CMake support maybe release after two month or later.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants