Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split_stack, stack function in utils.py #30

Open
nowhyun opened this issue Mar 3, 2022 · 0 comments
Open

split_stack, stack function in utils.py #30

nowhyun opened this issue Mar 3, 2022 · 0 comments

Comments

@nowhyun
Copy link

nowhyun commented Mar 3, 2022

Hi

first of all, thank you for your code

however,

Q1. shouldn't 'out_dim = featuers.shape[0]' be modified to 'out_dim = features.shape[1]' in the split_stack function?

Q2. shouldn't 'our[tar_idx] = features' be modified to 'out[tar_idx] += features' in the stack function?

@nowhyun nowhyun changed the title split_stack function in utils.py split_stack, stack function in utils.py Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant