Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header pill movement inconsistency #1

Open
wxiaoyun opened this issue Feb 26, 2024 · 3 comments
Open

Header pill movement inconsistency #1

wxiaoyun opened this issue Feb 26, 2024 · 3 comments

Comments

@wxiaoyun
Copy link

wxiaoyun commented Feb 26, 2024

Problem

When I scroll from top of the page to the about me section, the pill automatically moves from home to about. This behavior is not consistent with the rest of the sections

Expected

When I scroll to experience, the header pill moves to experience button.
The following is achieved by clicking on the experience tab
image

Actual

No pill movement when scrolling down
image

@wxiaoyun
Copy link
Author

Btw, bytegrad is such a great youtube channel. I learnt quite a bit about Next from him too 💯

@tankh99
Copy link
Owner

tankh99 commented Feb 26, 2024

Btw, bytegrad is such a great youtube channel. I learnt quite a bit about Next from him too 💯

Haha definitely one of the more educational and technical YouTubers. Jack Herrington is also pretty good!

@tankh99
Copy link
Owner

tankh99 commented Feb 26, 2024

Looks like this is an issue with react-intersection-observer not returning true for isInView...Will resolve this in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants