-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests seem to fail on windows. #583
Comments
ok, so there's a few issues here. the crlf thing is because on windows, you need to (before cloning) configure git with For the |
Then the tests seem to run: 294 passing, 9 pending.
Why don't you put .gitattributes in the repo? Anyhow, after that I get the following:
|
I could put gitattributes in the repo, but then i'd have to manually add a file to all of my repos, and that still wouldn't fix the underlying problem of Windows line endings for devs - until they learn to do this globally, at which point the per-repo file isn't needed anymore. The Good catch on the If |
I managed to get Any comments on that? And out of curiosity - why doesn't tape use itself to run tests? |
nyc 15 doesn't work on the older browser engines we support. Tape using itself to run tests is a bit strange imo; I think it would increase the chances in a bug being obscured. |
I believe this was fixed by #602 |
Tried running tape tests on windows. Got errors. Tried a bunch of stuff so just putting console output here:
The text was updated successfully, but these errors were encountered: