Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_observation_states takes contact_network as an argument but never uses it #113

Open
dburov190 opened this issue Jun 13, 2020 · 3 comments
Assignees

Comments

@dburov190
Copy link
Collaborator

Here
https://github.com/dburov190/risk-networks/blob/8d8bbfc0b61621d9ef48df22b33251dd8f386b64/epiforecast/measurements.py#L136-L139

contact_network is being passed into find_observation_states but is never used; is this a bug (and it should be used in some way) or is it safe to remove contact_network from the argument list?

@odunbar
Copy link
Collaborator

odunbar commented Jun 13, 2020

This is here because it is possible that we wish to target observations not only based on their current risk, but also the degree of the node.

@odunbar
Copy link
Collaborator

odunbar commented Jun 13, 2020

If you would like more consistency we could create an observation which uses it.

@dburov190
Copy link
Collaborator Author

I'd say the cleanest way is to simply delete it here and when (and if!) we ever need it, implement it then. Chances are, we'll never need it, and having an argument in a function that's never used is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants