Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DataAssimilator's responsibilities into two classes #173

Open
dburov190 opened this issue Aug 3, 2020 · 0 comments
Open

Split DataAssimilator's responsibilities into two classes #173

dburov190 opened this issue Aug 3, 2020 · 0 comments

Comments

@dburov190
Copy link
Collaborator

dburov190 commented Aug 3, 2020

At the moment, DataAssimilator is doing too many thing under the hood. A better way would be to separate observations out of this class, and only use it for "assimilation", i.e. perform incremental updates given a set of states and parameters, e.g.

observation = observer.perform_observation(ensemble_state, kinetic_state, user_nodes, time)
ensemble_state, ensemble_rates = assimilator.update(ensemble_state, ensemble_rates, observation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant