Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a replicaset from bucket map when this replicaset is removed from the cluster #11

Open
nurzhan-saktaganov opened this issue Jan 9, 2025 · 0 comments

Comments

@nurzhan-saktaganov
Copy link
Contributor

Original: KaymeKaydex/go-vshard-router#59

In RemoveReplicaset we remove replicaset from idToReplicaset map and close its connection pool.
But in routeMap we may still have pointers to this replicaset. This looks like a buggy behavior.

The straightforward solution with replacing to nil all elements of routeMap, that hold this pointer, doesn't work.
Because there might be a discovering goroutine that holds an old value of idToReplicaset that is still in progress.
Therefore, we need a bit more smart solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant