Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to backoff replica if request fails #485

Open
Serpentian opened this issue Aug 5, 2024 · 0 comments
Open

Allow to backoff replica if request fails #485

Serpentian opened this issue Aug 5, 2024 · 0 comments
Assignees
Labels
feature A new functionality router

Comments

@Serpentian
Copy link
Contributor

In mission critical systems requests cannot fail at all. We have automatic backoff procedure, which forbids to make requests to some instance for REPLICA_BACKOFF_INTERVAL, when storage is disabled or privileges weren't granted. I propose to extend its usage and allow users to configure it.

We'll introduce two new configuration options: can_backoff_after and backoff_timeout. can_backoff_after is a trigger, which accepts error, we got from a client, and a func name we tried to call. It returns true or false. If true is returned, replica goes into backoff state for backoff_timeout, no requests can be done to this replica, while it's in the backoff state.

This will allow users to minimize the number of failing requests a lot. Backoff procedure will be triggered when request to the instance fails or when ping in failover fails.

@Serpentian Serpentian added router feature A new functionality labels Aug 5, 2024
@Serpentian Serpentian self-assigned this Aug 5, 2024
@Serpentian Serpentian changed the title Allow to unconditionally backoff replica if request fails Allow to backoff replica if request fails Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality router
Projects
None yet
Development

No branches or pull requests

1 participant