Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tag for 1.2.0 #24

Open
mgorny opened this issue Dec 20, 2021 · 13 comments
Open

Missing tag for 1.2.0 #24

mgorny opened this issue Dec 20, 2021 · 13 comments

Comments

@mgorny
Copy link

mgorny commented Dec 20, 2021

Could you please push the tag for 1.2.0 release?

@tardyp
Copy link
Owner

tardyp commented Dec 20, 2021

done, and I also released an 1.2.1 and pushed the tag and gh release

@mgorny
Copy link
Author

mgorny commented Jan 2, 2022

Thanks. Could you push the tag for 1.3.0 now?

@tardyp
Copy link
Owner

tardyp commented Jan 3, 2022

Hello! pushed 1.3.0 and 1.4.0 this morning

@yan12125
Copy link

yan12125 commented Mar 9, 2022

The tag for 2.0.1 is also missing. Could you add it?

@SuperSandro2000
Copy link

Most of the code for 2.0.X is missing.

@tardyp
Copy link
Owner

tardyp commented Mar 31, 2022

There is no code this is just a readme fix

@SuperSandro2000
Copy link

According to the pyproject file the code is still on 1.4 https://github.com/tardyp/sphinx-jinja/blob/master/pyproject.toml#L3, not 2.0 or 2.0.1

@tardyp
Copy link
Owner

tardyp commented Mar 31, 2022

you are right I completly forgot to push the code sorry 🙇

@yan12125
Copy link

yan12125 commented Apr 1, 2022

Thanks! Here is a minor issue: new tags (2.0.0, 2.0.1) are not signed by your GPG key as per https://github.com/tardyp/sphinx-jinja/tags. Could you sign the tags?

I'm working on updating the Arch Linux package. In general, we prefer GPG-signed sources and do not remove GPG verification unless there is a good reason. For now, I use GPG-signed tags (https://github.com/archlinux/svntogit-community/blob/packages/python-sphinx-jinja/trunk/PKGBUILD#L17), and GPG-signed tarballs or other signed stuffs are also fine.

@SuperSandro2000
Copy link

And the 1.2.1 tag is duplicates once with v and without.

@yan12125
Copy link

yan12125 commented Jul 7, 2022

Tag 2.0.2 is still unsigned. @tardyp is there a plan to sign future tags or releases?

@tardyp
Copy link
Owner

tardyp commented Jul 7, 2022

@yan12125 sorryI just signed that tag

@yan12125
Copy link

yan12125 commented Jul 7, 2022

No problem and many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants