Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule and multiple flottbot instances #23

Open
wass3r opened this issue Oct 19, 2018 · 3 comments
Open

Schedule and multiple flottbot instances #23

wass3r opened this issue Oct 19, 2018 · 3 comments

Comments

@wass3r
Copy link
Collaborator

wass3r commented Oct 19, 2018

Call out in docs that the scheduler really only works with single bot instances

@mackenziegrimes
Copy link

While you're at updating docs, can you update the docs/example rules to have a six-argument cronjob schedule pattern?

In my experience, a bot will run with a second-minute-hour-etc pattern, not minute-hour-etc as the docs mention. Maybe both are supported?

Anyway, the cron library that flottbot uses seems to have 6 args https://github.com/robfig/cron/blob/61d93e07d1be270591d43ede700aa3ae69a2326f/parser.go#L120

@wass3r
Copy link
Collaborator Author

wass3r commented Aug 23, 2019

@mackenziegrimes yes, will do. we have a related issue about that here: target/flottbot#20

@wass3r
Copy link
Collaborator Author

wass3r commented Feb 14, 2020

it's been a minute, but the lib we're using got an update in the meantime.. i have something in queue to support both patterns, standard and quartz. i'll submit a PR for respective doc edits as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants