Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error when requested ReadTimeout is larger than supported max of 25.5s #98

Open
jaapz opened this issue Mar 4, 2019 · 1 comment
Open

Return an error when requested ReadTimeout is larger than supported max of 25.5s #98

jaapz opened this issue Mar 4, 2019 · 1 comment

Comments

@jaapz
Copy link

jaapz commented Mar 4, 2019

Took me a while of debugging to find out that timeouts given to ReadTimeout never go longer than 25.5 s. I work with a modem that can take 3 minutes to respond to certain commands.

Would by nice to have the init error out when a timeout higher than 25.5s is given, instead of silently limiting the min/max values of ReadTimeout.
@benma
Copy link

benma commented Nov 28, 2019

I ran into the same. It would also be great to document why this limit exists in the first place. Could it be increased?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaapz @benma