From 97d547c326b92d773ad9ec7d100d237d2a266c39 Mon Sep 17 00:00:00 2001 From: David Lopez Date: Fri, 17 Feb 2023 17:43:34 +0100 Subject: [PATCH 1/3] Remove deprecated `set-output` --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3127880..c5392d7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,12 +35,12 @@ jobs: - name: Get pip cache dir id: pip-cache run: | - echo "::set-output name=dir::$(pip cache dir)" + echo "PIP_DIR=dir::$(pip cache dir)" >> $GITHUB_OUTPUT - name: Cache uses: actions/cache@v3 with: - path: ${{ steps.pip-cache.outputs.dir }} + path: ${{ steps.pip-cache.outputs.PIP_DIR }} key: ${{ matrix.os }}-${{ matrix.python-version }}-v1-${{ hashFiles('**/tox.ini') }} restore-keys: | From 5ae5fa48cdb7e89cb6f3781e065e71455404e616 Mon Sep 17 00:00:00 2001 From: David Lopez Date: Fri, 17 Feb 2023 17:56:19 +0100 Subject: [PATCH 2/3] Use bash shell across all os --- .github/workflows/test.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c5392d7..d3488b3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,6 +8,9 @@ env: jobs: test: runs-on: ${{ matrix.os }} + defaults: + run: + shell: bash strategy: fail-fast: false matrix: @@ -35,7 +38,7 @@ jobs: - name: Get pip cache dir id: pip-cache run: | - echo "PIP_DIR=dir::$(pip cache dir)" >> $GITHUB_OUTPUT + echo "PIP_DIR=$(pip cache dir)" >> $GITHUB_OUTPUT - name: Cache uses: actions/cache@v3 From 96033b22f2141ee37581b68c705e8b03ed2c289d Mon Sep 17 00:00:00 2001 From: David Lopez Date: Fri, 17 Feb 2023 18:08:00 +0100 Subject: [PATCH 3/3] Use bash shell only on required steps to avoid changing shell on tests execution --- .github/workflows/test.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d3488b3..2149f6f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,9 +8,6 @@ env: jobs: test: runs-on: ${{ matrix.os }} - defaults: - run: - shell: bash strategy: fail-fast: false matrix: @@ -37,6 +34,7 @@ jobs: - name: Get pip cache dir id: pip-cache + shell: bash run: | echo "PIP_DIR=$(pip cache dir)" >> $GITHUB_OUTPUT