Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More developer-friendly Ember builds #2208

Open
a13o opened this issue Sep 30, 2023 · 3 comments
Open

More developer-friendly Ember builds #2208

a13o opened this issue Sep 30, 2023 · 3 comments

Comments

@a13o
Copy link

a13o commented Sep 30, 2023

The Ember TodoMVC app is currently minified, with sourcemaps disabled. This makes it difficult to browse the code from the todomvc website using devtools.

I would like to modify the Ember build config so that it doesn't minify and it contains sourcemaps.

This is in the spirit of the README:

We intentionally use the unminified versions to make reading the source code easier.

@FadySamirSadek
Copy link
Collaborator

Hello @a13o,

Thanks for highlighting this and your willingness to contribute, we appreciate it a lot. It's also worth noting that our Ember app was initialized with an older CLI version and hasn't incorporated the latest todomvc-app-css. Your assistance in updating this would be greatly valued.

On a related note, there were attempts to address similar concerns at #2140 and #2103. However, they remain unmerged due to a period of inactivity on this project. I recommend connecting with those contributors; their work might offer a starting point for your efforts. I am also here in case you need any assistance or support to get this completed and merged.

@NullVoxPopuli
Copy link
Contributor

I mean, I can rewrite it again 😅 ember apps today look even more different than the current one in this repeo.

@NullVoxPopuli
Copy link
Contributor

Started a PR here: #2209
I'll take it out of draft when I think it's in a good spot, I'm still upgrading stuff atm, but just wanted to leave a link trail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants