Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add window.navigate_to_url #5716

Closed
takkuumi opened this issue Nov 29, 2022 · 3 comments
Closed

[feat] Add window.navigate_to_url #5716

takkuumi opened this issue Nov 29, 2022 · 3 comments
Labels
status: backlog Issue is ready and we can work on it type: feature request

Comments

@takkuumi
Copy link

takkuumi commented Nov 29, 2022

Describe the problem

Now, We change the window url in a clumsy way.

The solution comes from #5377

main_window.eval(&format!("window.location.replace('http://localhost:{}')", "1234"));

Describe the solution you'd like

I think we can provide a new mod named location under window instance, The function of location can be partially similar to Window.location

Alternatives considered

No response

Additional context

No response

@amrbashir amrbashir changed the title [feat] Add api to window [feat] Add window.navigate_to_url Nov 29, 2022
@amrbashir
Copy link
Member

/upstream tauri-apps/wry

@tauri-apps tauri-apps bot added the status: upstream This issue is blocked by upstream dependencies and we need to wait or contribute upstream fixes label Nov 29, 2022
@tauri-apps
Copy link

tauri-apps bot commented Nov 30, 2022

Upstream issue at tauri-apps/wry#776 has been closed.

@tauri-apps tauri-apps bot added status: backlog Issue is ready and we can work on it and removed status: upstream This issue is blocked by upstream dependencies and we need to wait or contribute upstream fixes labels Nov 30, 2022
@jhutchins
Copy link
Contributor

I believe this was resolved with #7235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: backlog Issue is ready and we can work on it type: feature request
Projects
Status: 📬Proposal
Development

No branches or pull requests

3 participants