Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%-escaped characters in password #8

Open
DerFlob opened this issue May 5, 2018 · 1 comment
Open

%-escaped characters in password #8

DerFlob opened this issue May 5, 2018 · 1 comment

Comments

@DerFlob
Copy link

DerFlob commented May 5, 2018

%-escaped characters are not properly decoded. You added some replace-statements to "decode" exclamation and question marks. Unfortunately, my password includes a square bracket which won't be decoded and it fails to connect to the wifi.

I tried to integrate the unquote function from the urllib.parse module of the micropython/micropython-lib repo, though couldn't get it to work on an ESP8266 due to memory allocation issues.

Still I think it would be good to find a more general mechanism to decode %-escaped characters.

@ThomasWaldmann
Copy link
Collaborator

ThomasWaldmann commented May 5, 2018

guess we could save us a lot of troubles by just putting everything we need to persist into 1 data structure and then just pickle it. it's not human readable as it is now, but we save all the encoding/decoding troubles.

note: using json is no solution as it can not represent arbitrary bytestrings (and we need that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants