Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misidentification of Unity Projects #149

Open
jbienz opened this issue Dec 4, 2024 · 5 comments
Open

Misidentification of Unity Projects #149

jbienz opened this issue Dec 4, 2024 · 5 comments

Comments

@jbienz
Copy link

jbienz commented Dec 4, 2024

Kondo appears to sometimes misidentify Unity projects, though I don't know why. It may be when multiple Unity projects are children of a parent folder. For example, when cloning this project:

https://github.com/microsoft/Mesh-Toolkit-Unity

Kondo will detect Mesh101 and Mesh201 as regular .NET projects rather than Unity projects. This is true even if the projects have been opened in Unity and Unity has generated folders like Library.

image

Is this related to the detection work discussed here?

#111

And is there any known workaround for now? Supplying the full folder path to Kondo.exe doesn't seem to make a difference. Though I haven't found a way to get kondo.exe to tell me what type of project it thinks it is. Kondo.exe just tells me Projects cleaned: 0, Bytes deleted: 0.0B.

@tbillington
Copy link
Owner

Hey! Thanks for creating this issue :)

I'm pretty sure the .net/unity confusion is an issue I knew about previously and should have been already fixed before the most recent release of the ui, d48771c.

Do you know what version of the UI you're running, and where you obtained the program?

In general though yes the discovery rework should also handle this case, where a "unity project" is a more specific thing than a ".net project". This also applies to Godot projects, and I'm sure there's other cases that haven't been reported yet.

@tbillington
Copy link
Owner

Though I haven't found a way to get kondo.exe to tell me what type of project it thinks it is.

That (.NET) is directly outputing the name of the project type identified, used here in the ui, and implemented as such.

@tbillington
Copy link
Owner

Oh, as an aside, I'm creating a terminal interface for this tool in an upcoming version. As a user of the GUI on windows, is that something you'd consider using, or would you still prefer a native GUI style application?

828e63a565406b21.mp4

@juh9870
Copy link

juh9870 commented Dec 4, 2024

Terminal gui would be nice, especially for over-ssh work

@jbienz
Copy link
Author

jbienz commented Feb 3, 2025

Hey @tbillington, sorry it took me so long to reply.

Do you know what version of the UI you're running, and where you obtained the program?

I got them through UniGetUI (and therefore WinGet).

Package ID:  tbillington.kondo
Manifest:  https://github.com/microsoft/winget-pkgs/tree/master/manifests/t/tbillington/kondo
Version 0.8

Package ID:  tbillington.kondo.ui
Manifest:  https://github.com/microsoft/winget-pkgs/tree/master/manifests/t/tbillington/kondo/ui
Version 0.8

As far as I can tell, 0.8 appears to be the current version of both tools, correct?

I'm pretty sure the .net/unity confusion is an issue I knew about previously and should have been already fixed before the most recent release of the ui, d48771c.

It appears the date of that commit was December 11th, 2023, and it appears the date of the 0.8 binaries are December 19th, 2023. So that fix should be in the executable that I have, is that correct? If so, it does not appear to be working as expected.

As a user of the GUI on windows, is that something you'd consider using, or would you still prefer a native GUI style application?

In all honestly, I would personally still prefer a GUI. Primarily for discoverability without need to memorize CLI switches. But if the CLI UI is very discoverable, I would be open to it. I would still prefer a GUI, but I understand you only have so much time in a day.

Thank you so much for looking into this issue. And thank you for the valuable tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants