-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tt0490773 causes Undefined offset: 0 in Title.php:967 #155
Comments
Please test the master release. I think I already solved this in 2c181ba. I don't have any problem with this title at least. |
How to do that? I have 6.1.1 already installed |
You can download master.zip from here. And then unpack it in your vendor directory. |
Just as info This is why i suggested to do more releases to fixed problems. Certainly i don't expect a release for every fix but more often would be appreciated |
Sorry, I was in error before. Master release is fixed on Title.php:967 error but akas do not work in Master |
fixed this manually by inserting
to Title.php in line 973. Not too fancy but works for now. |
@duck7000 We know... The latest release where 4 days ago and released after a major breakage. This problem didn't even get raised, so hard to know if it actually affected people. FYI this is a type of comment that will get people to loose interest of contributing. Please raise a separate Issue if you want to discus it further. |
@jreklund Oke fair enough, it wasn't meant to upset anyone, no need to discus it further |
I reinstalled release 6.1.1 over master since in master akas field returns always empty. Correct? On 6.1.1 release title tt0490773 gives Undefined offset: 0 in E:\Laravel\videospace\vendor\imdbphp\imdbphp\src\Imdb\Title.php:967. So the original problem persists. I fixed it by returning empty array if $row[0] is not set in Title.php line 973 |
If that's the case master will fix your problem. It will only return an array in case it's not empty. Will make an release later with it applied. Before the fix Parsing::table() returned an array like this: |
yeah but master does not contain fix to empty akas problem |
It can't fetch something that aren't there: |
I tried the master version on several titles that have akas. Returned empty on all occasions. |
Can you give me some examples? Everything I feed it works. |
for example this did not return any akas for me yesterday when I had the master release installed: |
Okey, you must have made an mistake when installing it I'm afraid. I have now published v6.1.2 based on master. |
okay, It is possible that I may have made a mistake too. I will try out the new release later, Thanks! |
If the download are made recently and not cached for example 1 month, it won't be any issue as 6.1.1 and 6.1.2 are looking for the same ID. But if you are grabbing a one month old cache, it won't find it at all. As they constantly are changing the layout to break this library. But this time it should still work. As the ID are the same but with a different tag. But it's always good to clear /cache/ from time to time. |
yes I am aware that cache should be cleared and I did. However could be that I have forgotten to do it in some cases |
Full error report:
The text was updated successfully, but these errors were encountered: