-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bio page #303
Comments
Most likely imdb is started to update other parts/pages to the new ui style. Or it is happening because the search function does not always return results. I noticed that if i search the same title shortly after each other repeatably the first or second part of the function is used. Apparently imdb blocks using the same function in a short time. |
They're definitely updating the bio pages. I had a little more time to look into the problem, and I've noticed that there's at least two versions of it... Version 1 - the class properly grabs everything (old IMDb page) My regex skills are severely lacking, so I guess I'll leave my observations here and hope someone picks this up? |
Now there is no issue. It is ok! It was old type of page. When it is revised to new type of page of imdb website. it works well enough. |
It's random which page you'll get. Next time you scan the page, it may not work again. |
Jep same as the last time they changed imdb website.. |
I seem to remember there being some code in place last time to force the old version until the main code was updated. Anyone remember how to do that? |
I did a bit of a crash course in regex to get this going. I've fixed the following functions... they search for either the old bio page or the new one and will work with either. Works at the moment, subject to break whenever... This can likely be done smarter, but hey, it works....
|
It's possible that a nickname may have quotes or a comma in it on IMDb. These would break the function. So....
|
It does not work anymore. does not get data of person. Just name. |
I haven't had any problems. Try copying from here again? I may have edited the first post a day or so after I originally posted it. |
Thanks a lot! İt does get info of age, birthname , date and place But it doesnot get height , spouses and biography. |
hello |
@tboothman what about person class? |
Person Class is not urgent i think for you :( |
Hi @GeorgeFive! Any chance you also worked to update the bio() method? |
Hi @GeorgeFive i also need your asistance for the bio method spouse and height. Please if you have time ... |
Wonderful, tonight i am gonna check it ! |
@duck7000 Unfortunately it does not work. Because of differences arrays. |
I have combined comment and children because i think it all is a comment. You have to remember that my version is different/stripped down and i only added most (not all) methods from person class on request as i don't use it myself. And please don't comment here on methods used in my version, start a new issue at my version. This way comments are mixed up and confusing to others. |
I already tried to fix as you said. But i had another new issues and gave up. |
I've noticed that this has been going on for a few days now... maybe even a few weeks. Pieces of person data is just randomly not returning. Sometimes I get it, sometimes I don't. Refreshing will possibly give some pieces, possibly not. I don't see a rhyme or reason to it...?
I do not try to grab all data, but of the data I do grab....
Always works:
IMDb number
Name
Image
Sometimes works:
Birthday / born location
Died date / location / cause
Birth name
Nicknames
Test case: nm0001032
Name: Success!
Birth Name: Success!
Born: Failed!
Born Location: Failed!
Date Of Death: Success!
Location Of Death: Success!
Reload....
Name: Success!
Birth Name: Failed!
Born: Failed!
Born Location: Failed!
Date Of Death: Failed!
Location Of Death: Failed!
Reload....
Name: Success!
Birth Name: Success!
Born: Failed!
Born Location: Failed!
Date Of Death: Success!
Location Of Death: Success!
Reload....
Name: Success!
Birth Name: Success!
Born: Success!
Born Location: Success!
Date Of Death: Success!
Location Of Death: Success!
The text was updated successfully, but these errors were encountered: