Editorial: unify various forms of if-otherwise in single-line conditionals #3653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Jul 17, 2025
bakkot
approved these changes
Jul 17, 2025
Member
bakkot
left a comment
bakkot
left a comment
There was a problem hiding this comment.
I hit semantic satiation on "otherwise" about 20% of the way through this PR, but I'm pretty sure it's an improvement.
tontonialberto
force-pushed
the
unify-ifotherwise
branch
from
82bccd6 to
2aef93b
Compare
Contributor
|
The esmeta tycheck error in this PR looks a bit odd. I’ll look into it. |
This was referenced Jul 18, 2025
Contributor
|
I fixed the bug in ESMeta v0.6.3. After merging #3656, I hope this PR passes the esmeta typecheck. |
linusg
approved these changes
Jul 22, 2025
michaelficarra
added
editorial change
ready to merge
ljharb
pushed a commit
to tontonialberto/ecma262-inconsistency-fixes
that referenced
this pull request
Jul 24, 2025
ljharb
pushed a commit
to tontonialberto/ecma262-inconsistency-fixes
that referenced
this pull request
Jul 24, 2025
ljharb
force-pushed
the
unify-ifotherwise
branch
from
2aef93b to
889986d
Compare
ljharb
force-pushed
the
unify-ifotherwise
branch
from
889986d to
f764049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3648.
The following occurrences
If cond, s1. Otherwise s2If cond, s1. Otherwise, s2If cond, s1; otherwise, s2have been replaced with
If cond, s1; otherwise s2.