Skip to content

Commit 47ee2f4

Browse files
author
Charonops Jenkins Pipeline
committed
Merge 'trilinos/Trilinos:develop' (7ab1eec) into 'tcad-charon/Trilinos:develop' (33d2b9b).
* trilinos-develop: FMT: new version, nvidia fixes Fix shadowing warning IOSS: Fix shadowed variable warnings IOSS: Remove some IOSS_MAYBE_UNUSED until can determine why failing IOSS: Remove some IOSS_MAYBE_UNUSED until can determine why failing IOSS: lib{fmt} - revert unintended removal SEACAS: Tribits update IOSS: Multiple changes SEACAS: General changes SEACAS: Tribits update SEACAS: Add pragma once instead of include guards ATDM: Replace Trilinos_ASSERT_MISSING_PACKAGES with Trilinos_ASSERT_DEFINED_DEPENDENCIES (trilinos#11429) Automatic snapshot commit from tribits at bf7c58f6 Revert "Revert "TriBITS Snapshot 2022-12-12 working toward TriBITSPub/TriBITS#63""
2 parents 33d2b9b + 7ab1eec commit 47ee2f4

File tree

904 files changed

+8210
-7478
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

904 files changed

+8210
-7478
lines changed

CMakeLists.txt

+5-1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ INCLUDE(${CMAKE_CURRENT_LIST_DIR}/ProjectName.cmake)
6969
# not in an include file :-(
7070
PROJECT(${PROJECT_NAME} NONE)
7171

72+
# Set up to use ccache
7273
if($ENV{CCACHE_NODISABLE})
7374
# ccache must be requested explicitly by setting env-var CCACHE_NODISABLE
7475
find_program(CCACHE_PROGRAM ccache)
@@ -100,9 +101,12 @@ else()
100101
endif()
101102
endif()
102103

103-
## set an env so we know we are in configure
104+
# Set an env so we know we are in configure
104105
set(ENV{CMAKE_IS_IN_CONFIGURE_MODE} 1)
105106

107+
# Don't define TriBITS override of include_directories()
108+
set(TRIBITS_HIDE_DEPRECATED_INCLUDE_DIRECTORIES_OVERRIDE TRUE)
109+
106110
#
107111
# B) Pull in the TriBITS system and execute
108112
#

cmake/std/atdm/ATDMDevEnvSettings.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ ATDM_SET_CACHE(Trilinos_ENABLE_EXPLICIT_INSTANTIATION ON CACHE BOOL)
290290
#ATDM_SET_CACHE(HDF5_NO_SYSTEM_PATHS ${ATDM_HDF5_NO_SYSTEM_PATHS} CACHE BOOL)
291291
ATDM_SET_CACHE(Trilinos_ENABLE_INSTALL_CMAKE_CONFIG_FILES ON CACHE BOOL)
292292
ATDM_SET_CACHE(Trilinos_ENABLE_DEVELOPMENT_MODE OFF CACHE BOOL)
293-
ATDM_SET_CACHE(Trilinos_ASSERT_MISSING_PACKAGES ON CACHE BOOL)
293+
ATDM_SET_CACHE(Trilinos_ASSERT_DEFINED_DEPENDENCIES SEND_ERROR CACHE BOOL)
294294
ATDM_SET_CACHE(Trilinos_LINK_SEARCH_START_STATIC "${ATDM_Trilinos_LINK_SEARCH_START_STATIC}" CACHE BOOL)
295295
ATDM_SET_CACHE(Trilinos_ENABLE_OpenMP "${ATDM_USE_OPENMP}" CACHE BOOL)
296296
ATDM_SET_CACHE(Trilinos_ENABLE_COMPLEX "${ATDM_COMPLEX}" CACHE BOOL)

cmake/tribits/CHANGELOG.md

+93-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,99 @@
22
ChangeLog for TriBITS
33
----------------------------------------
44

5+
## 2023-01-10:
6+
7+
* **Added:** Added back support for deprecated variable
8+
`<Project>_ASSERT_MISSING_PACKAGES` that was removed
9+
[2022-10-11](#2022-10-11). When `<Project>_ASSERT_MISSING_PACKAGES` is set
10+
to a non-null value, it overrides the default value for
11+
`<Project>_ASSERT_DEFINED_DEPENDENCIES` (but setting
12+
`<Project>_ASSERT_DEFINED_DEPENDENCIES` in the cache takes precedence).
13+
14+
## 2023-01-06:
15+
16+
* **Changed:** Changed all TPL dependencies back to 'Optional' so that
17+
disabling an external package/TPL will **not** disable any downstream
18+
external packages/TPLs that list a dependency on that external package/TPL.
19+
This undoes the change on [2022-10-20](#2022-10-20) and restores backward
20+
compatibility to the behavior before that change.
21+
22+
## 2022-12-20:
23+
24+
* **Deprecated:** The macro `set_and_inc_dirs()` is deprecated and replaced by
25+
`tribits_set_and_inc_dirs()`. Use the script
26+
`TriBITS/refactoring/replace_set_and_inc_dirs_r.sh` to update
27+
`CMakeLists.txt` files.
28+
29+
## 2022-11-03:
30+
31+
* **Deprecated:** The long-deprecated TriBITS function override
32+
`include_directories()` now emits a deprecated warning. To replace all
33+
usages of `include_directories()` that should be
34+
`tribits_include_directories()`, use the script
35+
`TriBITS/refactoring/replace_include_directories_r.sh` (see documentation in
36+
that script).
37+
38+
* **Deprecated:** Many previously deprecated TriBITS features now will trigger
39+
a CMake DEPRECATION warning message by default (by calling
40+
`message(DEPRECATION ...)`). The message printed to the CMake output will
41+
typically describe how to remove the usage of the deprecated feature. To
42+
remove deprecation warnings, change to use the non-deprecated features
43+
mentioned in the deprecation warning message. To temporarily disable
44+
deprecation warnings, configure with `-D
45+
TRIBITS_HANDLE_TRIBITS_DEPRECATED_CODE=IGNORE` (see build reference entry
46+
for `TRIBITS_HANDLE_TRIBITS_DEPRECATED_CODE` for more details).
47+
48+
## 2022-10-20:
49+
50+
* **Changed:** Disabling an external package/TPL will now disable any
51+
downstream external packages/TPLs that list a dependency on that external
52+
package/TPL through its
53+
[`FindTPL<tplName>Dependencies.cmake`](https://tribitspub.github.io/TriBITS/users_guide/index.html#findtpl-tplname-dependencies-cmake)
54+
file. Prior to this, disabling an external package/TPL would not disable
55+
dependent downstream external packages/TPLs (it would only disable
56+
downstream dependent required internal packages). To avoid this, simply
57+
leave the enable status of the upstream external package/TPL empty "" and no
58+
downstream propagation of disables will take place.
59+
60+
## 2022-10-16:
61+
62+
* **Removed:** Removed the variables `<Project>_LIBRARY_DIRS`,
63+
`<Project>_TPL_LIST` and `<Project>_TPL_LIBRARIES` from the installed
64+
`<Project>Config.cmake` file. These are not needed after the change to
65+
modern CMake targets `<Package>::all_libs` (see `<Package>::all_libs`
66+
below). To determine if a TPL is enabled, check `if (TARGET
67+
<tplName>::all_libs)`. To get the libraries and include dirs for a TPL,
68+
link against the IMPORTED target `<tplName>::all_libs` (see the updated
69+
TriBITS example APP projects for details).
70+
71+
* **Removed:** Removed the variables `<Package>_PACKAGE_LIST`,
72+
`<Package>_TPL_LIST`, `<Package>_INCLUDE_DIR`, `<Package>_LIBRARY_DIRS`,
73+
`<Package>_TPL_INCLUDE_DIRS`, `<Package>_TPL_LIBRARIES` and
74+
`<Package>_TPL_LIBRARY_DIRS` from the generated `<Package>Config.cmake`
75+
files. These are not needed with the move to modern CMake targets (see
76+
`<Package>::all_libs` below).
77+
78+
* **Changed:** Changed `<Package>_LIBRARIES` in generated
79+
`<Package>Config.cmake` files from the full list of the package's library
80+
targets to just `<Package>::all_libs`. (There is no need to list the
81+
individual libraries after the move to modern CMake targets.)
82+
83+
## 2022-10-11:
84+
85+
* **Changed:** Added option `<Project>_ASSERT_DEFINED_DEPENDENCIES` to
86+
determine if listed external package/TPL and internal package dependencies
87+
are defined within the project or not. The initial default is `FATAL_ERROR`
88+
for development mode and `IGNORE` for release mode. (Previously, undefined
89+
external package/TPL dependencies where ignore.) To set a different
90+
default, set `<Project>_ASSERT_DEFINED_DEPENDENCIES_DEFAULT` to `WARNING`,
91+
for example, in the project's `ProjectName.cmake` file.
92+
93+
* **Removed:** `<Project>_ASSERT_MISSING_PACKAGES` has been removed and setting
94+
it will result in a `FATAL_ERROR`. Instead, use
95+
`<Project>_ASSERT_DEFINED_DEPENDENCIES` (and make sure all of your project's
96+
listed TPL dependencies are all defined within the project).
97+
598
## 2022-10-02:
699

7100
* **Changed:** The TriBITS FindTPLCUDA.cmake module changed
@@ -11,7 +104,6 @@ ChangeLog for TriBITS
11104
`find_package(CUDAToolkit)` (see [Trilinos
12105
#10954](https://github.com/trilinos/Trilinos/issues/10954)).
13106

14-
15107
## 2022-09-16:
16108

17109
* **Changed:** Changed nomenclature for packages and TPLs (see updated

cmake/tribits/ci_support/TribitsDumpDepsXmlScript.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ include(TribitsWriteXmlDependenciesFiles)
116116

117117
# Generate the dependencies file
118118

119-
set(${PROJECT_NAME}_ASSERT_MISSING_PACKAGES FALSE)
120-
set(${PROJECT_NAME}_OUTPUT_DEPENDENCY_FILES FALSE)
119+
set(${PROJECT_NAME}_ASSERT_DEFINED_DEPENDENCIES OFF)
120+
set(${PROJECT_NAME}_OUTPUT_DEPENDENCY_FILES FALSE)
121121
if (NOT ${PROJECT_NAME}_PRE_REPOSITORIES) # Make sure is defined!
122122
set(${PROJECT_NAME}_PRE_REPOSITORIES "")
123123
endif()

0 commit comments

Comments
 (0)