Semicolons should not be put on the next line

[nfcampos]

Describe the bug
Semicolons should not be put on the next line

To Reproduce

select * from revenue;

Expected behavior

select *
from revenue;

Actual behavior

select *
from revenue
;

Additional context
What is the output of sqlfmt --version?

sqlfmt, version 0.11.1

[tconbeer]

This is an intentional part of the style today. I like the visual separator when there are multiple queries in one file:

select *
from revenue
;

select *
from costs
;

(Unlike a language like javascript where a semicolon terminates each statement, here it terminates the whole query, so I feel that it should be at least as prominent as the main keywords in that query.)

What are the arguments for merging it with the last line?

[elyobo]

It's adding a lot of noise to a simple test file (supabase, pgtap) which inherently has many statements.

create extension if not exists "basejump-supabase_test_helpers";

begin
;

select plan(1)
;

select has_extension('basejump-supabase_test_helpers')
;

select *
from finish()
;
rollback
;

[nfcampos]

I see. Fair enough. I think this discussion might make more sense once you support DDL, as there multiple statements per file will be the norm rather than the exception. For what it’s worth empty lines are usually good visual separation for me. You could even enforce it by always adding eg. Two new lines after a semicolon?

…

On Mon, Oct 10 2022 at 7:49 pm, Ted Conbeer ***@***.***> wrote: This is an intentional part of the style today. I like the visual separator when there are multiple queries in one file: select *from revenue ; select *from costs ; (Unlike a language like javascript where a semicolon terminates each statement, here it terminates the whole query, so I feel that it should be at least as prominent as the main keywords in that query.) What are the arguments for merging it with the last line? — Reply to this email directly, view it on GitHub <#278 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAN4RTHO5WIVHO72KNZPHTWCRQKJANCNFSM6AAAAAARBS6HS4> . You are receiving this because you authored the thread.Message ID: ***@***.***>