Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tours not startet due to missing data? #18

Open
pixelbrackets opened this issue Feb 26, 2018 · 1 comment
Open

Tours not startet due to missing data? #18

pixelbrackets opened this issue Feb 26, 2018 · 1 comment

Comments

@pixelbrackets
Copy link

In some cases my tours dont start, because are not loaded yet. When I click one of them in the guide module, then the following errors appears in Console Log:

"startTour: MyTourName tour not found"

It seems that the tours is not loaded yet or not called via "loadTour()" first.
@pixelbrackets pixelbrackets mentioned this issue Feb 26, 2018
Open
@pixelbrackets
Copy link
Author

I made a quickfix and pushed a PR. However, this should be done differently some time in the future, as it slows down the backend performance.

pixelbrackets added a commit to webit-de/typo3-guide that referenced this issue Feb 26, 2018
@pixelbrackets
[BUGFIX] Load all tours on start already
909a00a 
Tour may not start and throw an error instead:
    "startTour: SomeTourName tour not found"

This is because the tour is not loaded/initialized yet.

with this fix all available tours are always loaded.

* Pro: Tours working again.
* Con: Very negative perfomance impact (one request &
  data handling for each tour)
  → his fix should be  replaced again soon

Refs tdeuling#18
pixelbrackets added a commit to webit-de/typo3-guide that referenced this issue Feb 27, 2018
@pixelbrackets
[BUGFIX] Load all tours on start already
b485092 
Tour may not start and throw an error instead:
    "startTour: SomeTourName tour not found"

This is because the tour is not loaded/initialized yet.

with this fix all available tours are always loaded.

* Pro: Tours working again.
* Con: Very negative perfomance impact (one request &
  data handling for each tour)
  → his fix should be  replaced again soon

Refs tdeuling#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelbrackets