Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation process could be more verbose #61

Open
MichaelChirico opened this issue Sep 24, 2024 · 2 comments
Open

Installation process could be more verbose #61

MichaelChirico opened this issue Sep 24, 2024 · 2 comments

Comments

@MichaelChirico
Copy link
Contributor

I was trying to peer through the install logs when thinking about Rdatatable/data.table#6528 and noticed that it's not clear from the logs what {atime} is doing vs. what the rest of the GHA process is doing.

I think it would be helpful to ensure {atime} makes a bit more noise, e.g. leading off the install chain with a nicely-formatted message along the lines of "atime is installing the following versioned copies of {package}: ".

@tdhock
Copy link
Owner

tdhock commented Sep 25, 2024

yes that would be nice.
right now the logic about deciding what package to install happens inside atime_pkg -> atime_versions -> atime_versions_exprs -> atime_versions_install
we would have to do a re-design which introduces a "analyze what we want to do" phase before the current "do some stuff" phase

@MichaelChirico
Copy link
Contributor Author

MichaelChirico commented Sep 25, 2024

I think for now even a "Beginning atime installation of pinned versions of {package}..." would be an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants