Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML formatter tweaks #18

Open
coreation opened this issue Jun 24, 2013 · 1 comment
Open

XML formatter tweaks #18

coreation opened this issue Jun 24, 2013 · 1 comment

Comments

@coreation
Copy link
Member

Problem

  1. Straight up utf8_encode'ing everything is quite frankly bad practice, at least a check should be done on which encoding is used on the data that enters the formatter.

  2. XML has a problem in its spec with a tag name starting with a numer, currently it's being solved by pre-pending an "i"-character in front of it, an underscore is better alternative.

Solution

Currently, the encoding should be removed, and the data just be displayed in the formatter. Replace the "i"-character with a defined pre-pending character, currently assigned with an underscore.

@coreation
Copy link
Member Author

@stevendebaveye , This should get you going again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant