test: 클래스 커스텀훅 테스트 코드 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdaxsz
reviewed
Dec 3, 2024
|
|
||
| // mocking useParams | ||
| const mockUseParams = (classId?: string, subClassId?: string) => { | ||
| vi.doMock('react-router-dom', () => ({ |
There was a problem hiding this comment.
오 doMock이라는 것도 있었네요. 배워갑니다!!
imdaxsz
reviewed
Dec 3, 2024
Comment on lines
+6
to
+10
| const setUser = (role: string | undefined) => { | ||
| vi.doMock('@/stores', () => ({ | ||
| default: () => ({ role }), | ||
| })); | ||
| }; |
There was a problem hiding this comment.
오오.. 저는 지금 로컬에 store를 그냥 테스트에 직접 가져와서 mock data 넣고, 접근하는 방식의 코드로 커밋했는데 이게 훨씬 좋아 보이네요 👍👍
imdaxsz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 개요
클래스 커스텀훅 테스트 코드
🚀 변경사항
🔗 관련 이슈
#231
➕ 기타